[PATCH] D40842: [ObjectYAML] Update obj2yaml and yaml2obj for .debug$H section

[Rui Ueyama via Phabricator via llvm-commits]

ruiu added inline comments.


================
Comment at: llvm/lib/ObjectYAML/CodeViewYAMLTypeHashing.cpp:51-54
+  BinaryStreamReader Reader(DebugT, llvm::support::little);
+  DebugHSection DHS;
+  cantFail(Reader.readInteger(DHS.Version));
+  cantFail(Reader.readInteger(DHS.HashAlgorithm));
----------------
zturner wrote:
> majnemer wrote:
> > Seeing as how nothing stops MSFT from using the debug$H section for something of their own invention, maybe we should have a magic four byte sequence at the section start to identify that we made it?
> Once we have this all working, I plan to send a modified copy of the PE/COFF spec to MS and see about getting it officially in the spec.  That said, wouldn't your concern already be addressed by the 16-bit `Version` field?
If Microsoft adds the same section with a different meaning, and if they decide to add a version field at the beginning of the section (it's not an unreasonable assumption), they would conflict, no?


https://reviews.llvm.org/D40842