[PATCH] D40849: CodeGen: support an extension to pass linker options on ELF
Saleem Abdulrasool via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Dec 5 14:11:49 PST 2017
compnerd added inline comments.
================
Comment at: lib/CodeGen/TargetLoweringObjectFileImpl.cpp:103
+ Directive.push_back(' ');
+ Directive.append(cast<MDString>(Option)->getString());
+ }
----------------
jakehehrlich wrote:
> Shouldn't the strings be separated by null characters instead?
No, this is the space for the "spaced option". See the test :-).
Repository:
rL LLVM
https://reviews.llvm.org/D40849
More information about the llvm-commits
mailing list