[PATCH] D40307: [MachineCombiner] Add up latencies of all instructions in new pattern.

[Gerolf Hoflehner via Phabricator via llvm-commits]

Gerolf added a comment.

I think your commit makes accounting for both cases - the instructions inserted and the instructions deleted - consistent. From that angle this look OK. I have also some food for thought: in both cases the code makes the assumption that it inserts a dependent instruction chain. Only then it is correct to simply add instruction latencies. I have not checked that this assumption is correct for all cases. So I suggest to add a comment about this. Assuming also that you don't see any notable perf regression you can go ahead and commit from my perspective: LGTM.

Thanks for working on this and your patience!
Cheers
Gerolf


https://reviews.llvm.org/D40307