[PATCH] D40512: [Debugify] Add a pass to test debug info preservation

[Vedant Kumar via Phabricator via llvm-commits]

vsk added inline comments.


================
Comment at: tools/opt/Debugify.cpp:54
+    }
+    return DTy;
+  };
----------------
davide wrote:
> should this be `return true`? 
This needs to return a DIType, but that could be made clearer. I'll make the return type explicit.


================
Comment at: tools/opt/Debugify.cpp:143-144
+
+      errs() << "ERROR: Instruction with empty DebugLoc -- ";
+      I.print(errs());
+      errs() << "\n";
----------------
davide wrote:
> I wonder whether this should be under `DEBUG()`, so that we don't clutter the release builds?
I'd rather not do that, since -check-debugify should indicate that the author is interested in messages related to debug info.


https://reviews.llvm.org/D40512