[PATCH] D40849: CodeGen: support an extension to pass linker options on ELF

Jake Ehrlich via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Dec 5 12:31:04 PST 2017


jakehehrlich added inline comments.


================
Comment at: lib/CodeGen/TargetLoweringObjectFileImpl.cpp:103
+        Directive.push_back(' ');
+        Directive.append(cast<MDString>(Option)->getString());
+      }
----------------
Shouldn't the strings be separated by null characters instead?


Repository:
  rL LLVM

https://reviews.llvm.org/D40849





More information about the llvm-commits mailing list