[PATCH] D40033: [NVPTX] Initial adaptation of MCAsmStreamer/MCTargetStreamer for debug info in Cuda.

[Artem Belevich via Phabricator via llvm-commits]

tra accepted this revision.
tra added a comment.
This revision is now accepted and ready to land.

LGTM in general. Can you think of a way to verify new functionality? It looks like we may have to wait until some target starts using it.



================
Comment at: lib/MC/MCAsmStreamer.cpp:1101
+  } else {
+    EmitRawText(OS1.str());
   }
----------------
We do not print EOL after the file name any more. Is that intentional?


================
Comment at: lib/MC/MCStreamer.cpp:62-64
+void MCTargetStreamer::emitDwarfFileDirective(StringRef Directive) {
+  Streamer.EmitRawText(Directive);
+}
----------------
Do you have further plans to do something more elaborate here? Otherwise I'd remove it and just use EmitRawText.


https://reviews.llvm.org/D40033