[PATCH] D40831: [AArch64] Only use writeback in the load/store optimizer when needed
Jun Bum Lim via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Dec 5 07:14:50 PST 2017
junbuml added inline comments.
================
Comment at: lib/Target/AArch64/AArch64LoadStoreOptimizer.cpp:1346
+ // We need to use writeback only when the base register is used afterwards.
+ bool UseWriteback = !getLdStBaseOp(*I).isKill();
+ unsigned NewOpc;
----------------
I'm not sure if it's safe enough to use the kill marker here? Is this information still valid for us to rely on?
Repository:
rL LLVM
https://reviews.llvm.org/D40831
More information about the llvm-commits
mailing list