[PATCH] D35267: Pass Divergence Analysis data to selection DAG to drive divergence dependent instruction selection

[Valery Pykhtin via Phabricator via llvm-commits]

vpykhtin added a comment.

In general adding "custom" code to SelectionDAGBuilder::setValue looks odd. Instead I would add a target-customizable postprocessing loop on pairs of Value <-> SDNode into SelectionDAGISel::SelectBasicBlock right after the DAG is created. The target hook should be able to get whatever it requires LLVM IR analisys and annotate SDNodes.



================
Comment at: lib/CodeGen/SelectionDAG/SelectionDAGISel.cpp:334
     AU.addRequired<BranchProbabilityInfoWrapperPass>();
+  AU.addRequired<DivergenceAnalysis>();
   MachineFunctionPass::getAnalysisUsage(AU);
----------------
this isn't fixed yet.


https://reviews.llvm.org/D35267