[llvm] r319752 - Fix build bot after r319750 "[Support/TarWriter] - Don't allow TarWriter to add the same file more than once."

George Rimar via llvm-commits llvm-commits at lists.llvm.org
Tue Dec 5 02:35:11 PST 2017


Author: grimar
Date: Tue Dec  5 02:35:11 2017
New Revision: 319752

URL: http://llvm.org/viewvc/llvm-project?rev=319752&view=rev
Log:
Fix build bot after r319750 "[Support/TarWriter] - Don't allow TarWriter to add the same file more than once."

Error was:
error: comparison of integers of different signs: 'const unsigned long' and 'const int' [-Werror,-Wsign-compare]

http://lab.llvm.org:8011/builders/ubuntu-gcc7.1-werror/builds/3469/steps/build-unified-tree/logs/stdio
http://lab.llvm.org:8011/builders/clang-with-thin-lto-ubuntu/builds/7118/steps/build-stage2-compiler/logs/stdio

Modified:
    llvm/trunk/unittests/Support/TarWriterTest.cpp

Modified: llvm/trunk/unittests/Support/TarWriterTest.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/unittests/Support/TarWriterTest.cpp?rev=319752&r1=319751&r2=319752&view=diff
==============================================================================
--- llvm/trunk/unittests/Support/TarWriterTest.cpp (original)
+++ llvm/trunk/unittests/Support/TarWriterTest.cpp Tue Dec  5 02:35:11 2017
@@ -136,7 +136,7 @@ TEST_F(TarWriterTest, SingleFile) {
   uint64_t TarSize;
   EC = sys::fs::file_size(Path, TarSize);
   EXPECT_FALSE((bool)EC);
-  EXPECT_EQ(TarSize, 2048);
+  EXPECT_EQ(TarSize, 2048ULL);
 }
 
 TEST_F(TarWriterTest, NoDuplicate) {
@@ -155,7 +155,7 @@ TEST_F(TarWriterTest, NoDuplicate) {
   uint64_t TarSize;
   EC = sys::fs::file_size(Path, TarSize);
   EXPECT_FALSE((bool)EC);
-  EXPECT_EQ(TarSize, 3072);
+  EXPECT_EQ(TarSize, 3072ULL);
 }
 
 TEST_F(TarWriterTest, Duplicate) {
@@ -174,6 +174,6 @@ TEST_F(TarWriterTest, Duplicate) {
   uint64_t TarSize;
   EC = sys::fs::file_size(Path, TarSize);
   EXPECT_FALSE((bool)EC);
-  EXPECT_EQ(TarSize, 2048);
+  EXPECT_EQ(TarSize, 2048ULL);
 }
 } // namespace




More information about the llvm-commits mailing list