[PATCH] D40779: [cmake] Fix zlib library detection
Pavel Labath via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Dec 5 02:28:39 PST 2017
labath added inline comments.
================
Comment at: cmake/config-ix.cmake:143
+ endif()
+ endforeach()
endif()
----------------
compnerd wrote:
> It might be nicer if this was out-of-lined.
I think that makes sense only if that code is made more generic so it can be re-used. I could make a patch that makes a more generic version of this, and then use that to implement the search for zlib and terminfo. What do you think?
Repository:
rL LLVM
https://reviews.llvm.org/D40779
More information about the llvm-commits
mailing list