[compiler-rt] r319464 - Move x86-specific sources to x86-specific source lists.

Yvan Roux via llvm-commits llvm-commits at lists.llvm.org
Tue Dec 5 01:50:31 PST 2017


> Should be fixed by rL319669. Let me know if I need to do more.

The bots are green, Thanks.

Yvan

> On Mon, Dec 4, 2017 at 9:04 AM, Sterling Augustine <saugustine at google.com>
> wrote:
>>
>> Working on a fix.
>>
>> On Mon, Dec 4, 2017 at 6:15 AM, Yvan Roux <yvan.roux at linaro.org> wrote:
>>>
>>> Hi,
>>>
>>> AArch64 bot is broken since this commit, the issue is that these
>>> compiler-rt tests are not flagged as x86 specific and/or are not
>>> skipped if HAS_80_BIT_LONG_DOUBLE is not defined.
>>>
>>> builtins/Unit/divxc3_test.c
>>> builtins/Unit/mulxc3_test.c
>>> builtins/Unit/powixf2_test.c
>>>
>>> Yvan
>>>
>>> On 30 November 2017 at 20:39, Sterling Augustine via llvm-commits
>>> <llvm-commits at lists.llvm.org> wrote:
>>> > Author: saugustine
>>> > Date: Thu Nov 30 11:39:33 2017
>>> > New Revision: 319464
>>> >
>>> > URL: http://llvm.org/viewvc/llvm-project?rev=319464&view=rev
>>> > Log:
>>> > Move x86-specific sources to x86-specific source lists.
>>> >
>>> > Modified:
>>> >     compiler-rt/trunk/lib/builtins/CMakeLists.txt
>>> >
>>> > Modified: compiler-rt/trunk/lib/builtins/CMakeLists.txt
>>> > URL:
>>> > http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/lib/builtins/CMakeLists.txt?rev=319464&r1=319463&r2=319464&view=diff
>>> >
>>> > ==============================================================================
>>> > --- compiler-rt/trunk/lib/builtins/CMakeLists.txt (original)
>>> > +++ compiler-rt/trunk/lib/builtins/CMakeLists.txt Thu Nov 30 11:39:33
>>> > 2017
>>> > @@ -51,7 +51,6 @@ set(GENERIC_SOURCES
>>> >    cmpti2.c
>>> >    comparedf2.c
>>> >    comparesf2.c
>>> > -  cpu_model.c
>>> >    ctzdi2.c
>>> >    ctzsi2.c
>>> >    ctzti2.c
>>> > @@ -66,7 +65,6 @@ set(GENERIC_SOURCES
>>> >    divtc3.c
>>> >    divti3.c
>>> >    divtf3.c
>>> > -  divxc3.c
>>> >    extendsfdf2.c
>>> >    extendhfsf2.c
>>> >    ffsdi2.c
>>> > @@ -84,27 +82,18 @@ set(GENERIC_SOURCES
>>> >    fixunssfdi.c
>>> >    fixunssfsi.c
>>> >    fixunssfti.c
>>> > -  fixunsxfdi.c
>>> > -  fixunsxfsi.c
>>> > -  fixunsxfti.c
>>> > -  fixxfdi.c
>>> > -  fixxfti.c
>>> >    floatdidf.c
>>> >    floatdisf.c
>>> > -  floatdixf.c
>>> >    floatsidf.c
>>> >    floatsisf.c
>>> >    floattidf.c
>>> >    floattisf.c
>>> > -  floattixf.c
>>> >    floatundidf.c
>>> >    floatundisf.c
>>> > -  floatundixf.c
>>> >    floatunsidf.c
>>> >    floatunsisf.c
>>> >    floatuntidf.c
>>> >    floatuntisf.c
>>> > -  floatuntixf.c
>>> >    int_util.c
>>> >    lshrdi3.c
>>> >    lshrti3.c
>>> > @@ -124,7 +113,6 @@ set(GENERIC_SOURCES
>>> >    mulvdi3.c
>>> >    mulvsi3.c
>>> >    mulvti3.c
>>> > -  mulxc3.c
>>> >    negdf2.c
>>> >    negdi2.c
>>> >    negsf2.c
>>> > @@ -142,7 +130,6 @@ set(GENERIC_SOURCES
>>> >    powidf2.c
>>> >    powisf2.c
>>> >    powitf2.c
>>> > -  powixf2.c
>>> >    subdf3.c
>>> >    subsf3.c
>>> >    subvdi3.c
>>> > @@ -226,6 +213,23 @@ if (NOT FUCHSIA)
>>> >      clear_cache.c)
>>> >  endif()
>>> >
>>> > +# These sources work on all x86 variants, but only x86 variants.
>>> > +set(x86_ARCH_SOURCES
>>> > +  cpu_model.c
>>> > +  divxc3.c
>>> > +  fixxfdi.c
>>> > +  fixxfti.c
>>> > +  fixunsxfdi.c
>>> > +  fixunsxfsi.c
>>> > +  fixunsxfti.c
>>> > +  floatdixf.c
>>> > +  floattixf.c
>>> > +  floatundixf.c
>>> > +  floatuntixf.c
>>> > +  mulxc3.c
>>> > +  powixf2.c
>>> > +)
>>> > +
>>> >  if (NOT MSVC)
>>> >    set(x86_64_SOURCES
>>> >        x86_64/chkstk.S
>>> > @@ -284,6 +288,11 @@ else () # MSVC
>>> >    set(i386_SOURCES ${GENERIC_SOURCES})
>>> >  endif () # if (NOT MSVC)
>>> >
>>> > +set(x86_64h_SOURCES ${x86_64h_SOURCES} ${x86_ARCH_SOURCES})
>>> > +set(x86_64_SOURCES ${x86_64_SOURCES} ${x86_ARCH_SOURCES})
>>> > +set(i386_SOURCES ${i386_SOURCES} ${x86_ARCH_SOURCES})
>>> > +set(i686_SOURCES ${i686_SOURCES} ${x86_ARCH_SOURCES})
>>> > +
>>> >  set(arm_SOURCES
>>> >    arm/bswapdi2.S
>>> >    arm/bswapsi2.S
>>> >
>>> >
>>> > _______________________________________________
>>> > llvm-commits mailing list
>>> > llvm-commits at lists.llvm.org
>>> > http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
>>
>>
>


More information about the llvm-commits mailing list