[PATCH] D38406: [dump] Remove NDEBUG from test to enable dump methods [NFC]

[Matthias Braun via Phabricator via llvm-commits]

MatzeB added a comment.

In https://reviews.llvm.org/D38406#944576, @hintonda wrote:

> Re-opening:
>
> This was reverted in https://reviews.llvm.org/rL315854 due to bot failures using multi-configuration generators, e.g., XCode and MSVC.
>
> There were 2 issues:
>
> 1. LLVM_ENABLE_DEBUG was missing on some dump declartions,
> 2. LLVM_ENABLE_DEBUG was set based on CMAKE_BUILD_TYPE which isn't set when using multi-configuration generators.
>
>   We can fix 1 as needed, and 2 by adding LLVM_ENABLE_DUMP to CMAKE_CXX_FLAGS_(RELEASE|MINSIZEREL) as needed.


Just some brainstorming for the generator problems (didn't really check if cmake is flexible enough to pull this off): Would it be possible to do cmake hackery to create a directory for every CMAKE_BUILD_TYPE and then generate the llvm-config.h apropriate for each BUILT_TYPE into each directory and add an -I flag to the flags of each build type.


Repository:
  rL LLVM

https://reviews.llvm.org/D38406