[PATCH] D40606: [Support/TarWriter] - Don't allow TarWriter to add the same file more than once.

[Rui Ueyama via Phabricator via llvm-commits]

ruiu accepted this revision.
ruiu added a comment.

LGTM with this change.



================
Comment at: unittests/Support/TarWriterTest.cpp:142
+
+TEST_F(TarWriterTest, TwoDifferentFilesSize) {
+  SmallString<128> Path;
----------------
These test names made me think for a while why you needed to check for file size (e.g. did we have a logic to pick the largest file or something?)

It turned out that you are using file size just to verify that output is correct.

Please rename these tests SingleFile, NoDuplicate and Duplicate.


https://reviews.llvm.org/D40606