[PATCH] D40699: Split IndirectBr critical edges before PGO gen/use passes.

Eli Friedman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Dec 4 15:44:17 PST 2017


efriedma added a comment.

> It's an improvement in that it can handle single indirectbr predecessor cases.

It's not good to kick the can down the road like this.  If an IR optimization pass is crashing, you should fix it by fixing that pass, not by changing the default pass pipeline to avoid generating IR which triggers the crash.


https://reviews.llvm.org/D40699





More information about the llvm-commits mailing list