spatel accepted this revision. spatel added a comment. This revision is now accepted and ready to land. LGTM. We have at least 2 suggestions to improve the AMDGPU tests, but we shouldn't need to hold up this patch for that fix. https://reviews.llvm.org/D40231