[PATCH] D40792: DAG: Match truncated rotation (PR35487)

[Hans Wennborg via Phabricator via llvm-commits]

hans added inline comments.


================
Comment at: lib/CodeGen/SelectionDAG/DAGCombiner.cpp:4657
+  if (LHS.getOpcode() == ISD::TRUNCATE && RHS.getOpcode() == ISD::TRUNCATE) {
+    assert(LHS.getValueType() == RHS.getValueType());
+    if (SDNode *Rot = MatchRotate(LHS.getOperand(0), RHS.getOperand(0), DL)) {
----------------
efriedma wrote:
> Do you need to check that `LHS.getOperand(0).getValueType() == RHS.getOperand(0).getValueType()`?
Sorry, just hit commit before I saw this. You're right, I need to check that.


Repository:
  rL LLVM

https://reviews.llvm.org/D40792