[PATCH] D40049: [PATCH] Global reassociation for improved CSE

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.


================
Comment at: lib/Transforms/Scalar/Reassociate.cpp:2255
+        }
+        // be paranoid about self-referencing expressions in unreachable code
+        if (OpI->getOperand(0) != OpI)
----------------
Capitalize


================
Comment at: lib/Transforms/Scalar/Reassociate.cpp:2273
+          Value *Op1 = Ops[j];
+          if (std::less<Value *>()(Op1, Op0))
+            std::swap(Op0, Op1);
----------------
I'm not sure what std::less on a Value * means. Is this sorting by pointer value?


Repository:
  rL LLVM

https://reviews.llvm.org/D40049