[PATCH] D40362: [TableGen][AsmMatcherEmitter] Only choose specific diagnostic for enabled instruction

Oliver Stannard via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Dec 4 09:14:21 PST 2017


olista01 accepted this revision.
olista01 added a comment.
This revision is now accepted and ready to land.

This is very similar to what I'm doing with the multiple-near-miss diagnostics, trying to only emit messages which point out exactly what is wrong with an instruction, rather than simply the first thing the assembler found wrong. Hopefully this will be made obsolete once I get the near-miss mechanism completed and ported to non-ARM targets, but this looks like a reasonable point fix in the meantime. LGTM.


https://reviews.llvm.org/D40362





More information about the llvm-commits mailing list