[PATCH] D40735: [LLD][ELF] InX::BssRelRo should check section contents before marking relro

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Dec 4 06:12:45 PST 2017


jhenderson added inline comments.


================
Comment at: test/ELF/relro-copyrel-bss-script.s:4-5
+// RUN: ld.lld -shared %t.o -o %t.so
+// A linker script that will map .bss.rel.ro into .bss. If we don't have any
+// .bss.rel.ro then we don't want to mark .bss as being relro.
+// RUN: echo "SECTIONS { \
----------------
Is there a different test already for the opposite case, where we have .bss.rel.ro (with or without any other .bss), but with the same script? If not, I think that it would be beneficial to add it.


https://reviews.llvm.org/D40735





More information about the llvm-commits mailing list