[PATCH] D28335: [WIP] [RFC] Don't lower floating point intrinsics to libcalls which modify errno

Sanjay Patel via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Dec 3 09:43:52 PST 2017


spatel added a comment.

I think we have clang doing the expected thing after:

https://reviews.llvm.org/rL317031 ( https://reviews.llvm.org/D39204 )
https://reviews.llvm.org/rL317265 ( https://reviews.llvm.org/D39481 )
https://reviews.llvm.org/rL317407 ( https://reviews.llvm.org/D39615 )
https://reviews.llvm.org/rL318093 ( https://reviews.llvm.org/D39641 )
https://reviews.llvm.org/rL318598 ( https://reviews.llvm.org/D39611 )
https://reviews.llvm.org/rL319593 ( https://reviews.llvm.org/D40044 )
https://reviews.llvm.org/rL319619

...if you still see bugs up there, let me know.

Instead of:
"Fix clang so it doesn't generate calls to llvm.sqrt() and llvm.pow() when they aren't available."
We're deferring that to LLVM to save/restore errno somehow, but that's not done yet.


Repository:
  rL LLVM

https://reviews.llvm.org/D28335





More information about the llvm-commits mailing list