[PATCH] D39392: Do not add weak undefined symbols to .dynsym unless -pic or -shared are given.

[Rafael Avila de Espindola via llvm-commits]

Rui Ueyama <ruiu at google.com> writes:

> I'm not sure if you understand the problem I'm trying to resolve.
>
> IIUC, what https://bugs.llvm.org/show_bug.cgi?id=34301#c5 claims as a bug
> is not a bug.

No, sorry. It is a bug.

The user found a difference in behavior that broke a feature they
depended on. That worked on bfd and gold. They were kind enough to
report the issue and we fixed it. We should not break it.

> Weak external symbols that were not compiled with -fPIC are fundamentally
> not representable when they are resolved to other DSOs.

They were compiled with -fPIC. The comment says:

clang -o dummy dummy.c -fPIC

Cheers,
Rafael