[PATCH] D40724: Wasm entrypoint changes #1 (add --undefined argument to LLD) APPLY AFTER D40690

Rui Ueyama via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Dec 1 13:00:47 PST 2017


ruiu added inline comments.


================
Comment at: wasm/Driver.cpp:281
     error("entry point specified for relocatable output file");
+  if (Config->Relocatable && !Undefined.empty())
+    error("undefined symbols specified for relocatable output file");
----------------
I'd change this to `if (Config->Relocatable && Args.hasArgs(OPT_undefined))` so that we can remove `Undefined` variable.


Repository:
  rLLD LLVM Linker

https://reviews.llvm.org/D40724





More information about the llvm-commits mailing list