[PATCH] D40606: [Support/TarWriter] - Don't allow TarWriter to add the same file more than once.

Rui Ueyama via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Dec 1 12:01:11 PST 2017


ruiu added inline comments.


================
Comment at: unittests/Support/TarWriterTest.cpp:124-143
+TEST_F(TarWriterTest, MultipleFiles) {
+  SmallString<128> Path;
+  std::error_code EC =
+      sys::fs::createTemporaryFile("TarWriterTest", "tar", Path);
+  EXPECT_FALSE((bool)EC);
+
+  size_t SingleFileTarSize;
----------------
You should split this into three different test functions.


https://reviews.llvm.org/D40606





More information about the llvm-commits mailing list