[PATCH] D40725: Wasm entrypoint changes #3 (add --no-entry argument to LLD) APPLY AFTER D40559

[Dan Gohman via Phabricator via llvm-commits]

sunfish added inline comments.


================
Comment at: wasm/Driver.cpp:226
+    return def;
+  // Apparently the empty string is a valid symbol name in Wasm, so we use a
+  // null string to mean "no entrypoint", *not* the empty string.
----------------
sbc100 wrote:
> Empty string is not a valid symbol name.   Do you have some reason to believe it is?
There's a test for it: https://github.com/WebAssembly/testsuite/blob/master/names.wast#L20


Repository:
  rLLD LLVM Linker

https://reviews.llvm.org/D40725