[PATCH] D40710: [LLD][ELF] Revert r318924 Skip over empty sections when checking for contiguous relro

[Rafael Avila de Espindola via llvm-commits]

Revert LGTM while we figure out the right thing to do.


Peter Smith via Phabricator <reviews at reviews.llvm.org> writes:

> peter.smith created this revision.
> Herald added a subscriber: emaste.
>
> PR35478 https://bugs.llvm.org/show_bug.cgi?id=35478 points out a flaw in the implementation of r318924 from https://reviews.llvm.org/D40364. The implementation depends on the Size field being set or the SyntheticSection::empty() being accurate. These functions are not reliable as some linker script commands that have yet to be processed may affect the results, causing some non-zero size sections to be reported as zero size.
>
> I think the first step is to revert r318924 and come up with a better solution for the underlying problem rather than trying to layer more heuristics onto the zero sized output section.
>
> Chances are I'll be out of office by the time anyone sees this so feel free to commit the revert if you agree with me.

Will do.

Cheers,
Rafael