[PATCH] D40692: AMDGPU/EG: Add a new FeatureFMA and use it to selectively enable FMA instruction

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.


================
Comment at: lib/Target/AMDGPU/R600Instructions.td:989
 
+let OtherPredicates = [FMA] in {
 class FMA_Common <bits<5> inst> : R600_3OP <
----------------
I'm somewhat surprised this works. I would expect you need to do 

{ 

  let OtherPredicates = ..
}

inside the class body, since the let block isn't around the instantiations of this.


Repository:
  rL LLVM

https://reviews.llvm.org/D40692