[PATCH] D40696: Enable aggressive FMA on T99 and provide AArch64 option for other micro-arch's

[Stefan Teleman via Phabricator via llvm-commits]

steleman added inline comments.


================
Comment at: test/CodeGen/AArch64/fma-aggressive.ll:1
+; RUN: llc -O2 -mtriple=aarch64-none-linux-gnu -mcpu=thunderx2t99 -fp-contract=fast < %s | FileCheck %s
+; This test program demonstrates the effects of enabling aggressive FMA
----------------
fhahn wrote:
> I think it would be good to also add a check that aggressive FMA is not enabled for other micro architectures.
OK I'll add another test named 'fma-not-aggressive.ll' :-)



================
Comment at: test/CodeGen/AArch64/fma-aggressive.ll:323
+
+attributes #0 = { nounwind "correctly-rounded-divide-sqrt-fp-math"="false" "disable-tail-calls"="false" "less-precise-fpmad"="false" "no-frame-pointer-elim"="true" "no-frame-pointer-elim-non-leaf" "no-infs-fp-math"="true" "no-jump-tables"="false" "no-nans-fp-math"="true" "no-signed-zeros-fp-math"="true" "no-trapping-math"="true" "stack-protector-buffer-size"="8" "target-cpu"="thunderx2t99" "target-features"="+lse,+neon,+v8.1a" "unsafe-fp-math"="true" "use-soft-float"="false" }
+attributes #1 = { argmemonly nounwind }
----------------
fhahn wrote:
> Can we drop the meta data from here to the end or is it required for the test?
I'll check and if it works without the metadata, I'll remove it.


Repository:
  rL LLVM

https://reviews.llvm.org/D40696