[llvm] r319539 - Revert r319537: Bail out of a SimplifyCFG switch table opt at undef values.

Mikael Holmen via llvm-commits llvm-commits at lists.llvm.org
Fri Dec 1 05:11:40 PST 2017


Author: uabelho
Date: Fri Dec  1 05:11:39 2017
New Revision: 319539

URL: http://llvm.org/viewvc/llvm-project?rev=319539&view=rev
Log:
Revert r319537: Bail out of a SimplifyCFG switch table opt at undef values.

Broke build bots so reverting.

Removed:
    llvm/trunk/test/Transforms/SimplifyCFG/switch_undef.ll
Modified:
    llvm/trunk/lib/Transforms/Utils/SimplifyCFG.cpp

Modified: llvm/trunk/lib/Transforms/Utils/SimplifyCFG.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Transforms/Utils/SimplifyCFG.cpp?rev=319539&r1=319538&r2=319539&view=diff
==============================================================================
--- llvm/trunk/lib/Transforms/Utils/SimplifyCFG.cpp (original)
+++ llvm/trunk/lib/Transforms/Utils/SimplifyCFG.cpp Fri Dec  1 05:11:39 2017
@@ -5174,7 +5174,7 @@ static void reuseTableCompare(
   for (auto ValuePair : Values) {
     Constant *CaseConst = ConstantExpr::getICmp(CmpInst->getPredicate(),
                                                 ValuePair.second, CmpOp1, true);
-    if (!CaseConst || CaseConst == DefaultConst || isa<UndefValue>(CaseConst))
+    if (!CaseConst || CaseConst == DefaultConst)
       return;
     assert((CaseConst == TrueConst || CaseConst == FalseConst) &&
            "Expect true or false as compare result.");

Removed: llvm/trunk/test/Transforms/SimplifyCFG/switch_undef.ll
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/Transforms/SimplifyCFG/switch_undef.ll?rev=319538&view=auto
==============================================================================
--- llvm/trunk/test/Transforms/SimplifyCFG/switch_undef.ll (original)
+++ llvm/trunk/test/Transforms/SimplifyCFG/switch_undef.ll (removed)
@@ -1,27 +0,0 @@
-; RUN: opt %s -keep-loops=false -switch-to-lookup=true -simplifycfg -S | FileCheck %s
-
-target triple = "x86_64-unknown-linux-gnu"
-
-define void @f6() #0 {
-; CHECK-LABEL: entry:
-; CHECK-NEXT:  br label %f1.exit.i
-; CHECK-LABEL: f1.exit.i:
-
-entry:
-  br label %for.cond.i
-
-for.cond.i:                                       ; preds = %f1.exit.i, %entry
-  switch i16 undef, label %f1.exit.i [
-    i16 -1, label %cond.false.i3.i
-    i16 1, label %cond.false.i3.i
-    i16 0, label %cond.false.i3.i
-  ]
-
-cond.false.i3.i:                                  ; preds = %for.cond.i, %for.cond.i, %for.cond.i
-  br label %f1.exit.i
-
-f1.exit.i:                                        ; preds = %cond.false.i3.i, %for.cond.i
-  %cond.i4.i = phi i16 [ undef, %cond.false.i3.i ], [ 1, %for.cond.i ]
-  %tobool7.i = icmp ne i16 %cond.i4.i, 0
-  br label %for.cond.i
-}




More information about the llvm-commits mailing list