[PATCH] D40646: [mips] Enable the mnemonic spell corrector
Simon Atanasyan via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Dec 1 03:30:49 PST 2017
atanasyan added a comment.
In https://reviews.llvm.org/D40646#940759, @sdardis wrote:
> The swe there is potentially refering to the micromips or the micromipsr6 version. swl and swr should not be on the list.
>
> There's a number of instructions which don't have the correct predicates, so the spelling checker will deliver the wrong results, as the set of possible corrections is dependant on the feature bits that are enabled.
>
> I have been working on a patch set to correct / rework the instruction predicates which I should start posting next week.
>
> I think we should hold off on enabling this until the instruction predicates have been fixed.
Good point. Let's wait for the instruction predicates fixing.
Repository:
rL LLVM
https://reviews.llvm.org/D40646
More information about the llvm-commits
mailing list