[PATCH] D40606: [Support/TarWriter] - Don't allow TarWriter to add the same file more than once.

George Rimar via llvm-commits llvm-commits at lists.llvm.org
Fri Dec 1 03:29:23 PST 2017


>The code change LGTM.
>
>The TarWriter is tested in llvm with unittests. Can you add a test
>showing that if the same path is added twice we only keep the first one?
>
>Thanks,
>Rafael

Updated diff, added testcase. It checks tar file size do not change when we add
multiple files for the same path. Do it checks only one file is used, but does not check
which one. Looks it is fine for now ?

George.


More information about the llvm-commits mailing list