[PATCH] D40098: [AMDGPU] Improve hazard checks for inline asm statements

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Nov 30 11:53:57 PST 2017


arsenm accepted this revision.
arsenm added a comment.
This revision is now accepted and ready to land.

LGTM with formatting fixed



================
Comment at: lib/Target/AMDGPU/GCNHazardRecognizer.cpp:519
 
+int GCNHazardRecognizer::checkVALUHazardsHelper(const MachineOperand &Def, const MachineRegisterInfo &MRI) {
+  // Helper to check for the hazard where VMEM instructions that store more than
----------------
This looks like it goes over 80 lines


================
Comment at: lib/Target/AMDGPU/GCNHazardRecognizer.cpp:548
 
-  const SIRegisterInfo *TRI = ST.getRegisterInfo();
   const MachineRegisterInfo &MRI = VALU->getParent()->getParent()->getRegInfo();
   int WaitStatesNeeded = 0;
----------------
MF.getRegInfo()


https://reviews.llvm.org/D40098





More information about the llvm-commits mailing list