[PATCH] D40695: Improve loop unrolling performance on T99

Eli Friedman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Nov 30 19:11:45 PST 2017


efriedma accepted this revision.
efriedma added a comment.
This revision is now accepted and ready to land.

LGTM.

> Larger than 128 doesn't improve performance or increase unrolling -- at least on SPECcpu2017, libquantum and Google Protobufs, on T99.

For benchmarking, just wanted to make sure you did some wider testing; I don't care about the LLVM testsuite specifically.

> That's something I would be happy to take a look at, but I am reluctant, for now, to make changes in AArch64TTIImpl::getUnrollingPreferences. That's a more involved change.

Sure, that's fine.


Repository:
  rL LLVM

https://reviews.llvm.org/D40695





More information about the llvm-commits mailing list