[PATCH] D40696: Enable aggressive FMA on T99 and provide AArch64 option for other micro-arch's

[Matthias Braun via Phabricator via llvm-commits]

MatzeB added a comment.

In https://reviews.llvm.org/D40696#941556, @steleman wrote:

> In https://reviews.llvm.org/D40696#941537, @MatzeB wrote:
>
> > My points from https://reviews.llvm.org/D40177 still stand.
>
>
> Your points from https://reviews.llvm.org/D40177 require unnecessary changes to too many files, and do not prevent changes to AArch64ISelLowering.cpp whenever a new micro-arch wants to enable aggressive FMA.
>
> Furthermore, every single time a new micro-arch wants to enable aggressive FMA, they will always have to edit **two** TU's instead of just one: AArch64.td and AArch64ISelLowering.cpp, instead of just adding a new line to the existing switch() statement in AArch64TargetLowering::enableAggressiveFMAFusion().


You would not need to edit AArch64ISelLowering again after adding a subtargetfeature.


Repository:
  rL LLVM

https://reviews.llvm.org/D40696