[PATCH] D40688: [lld] Switch to add_llvm_install_targets

[Rafael Avila de Espindola via llvm-commits]

LGTM


Shoaib Meenai via Phabricator via llvm-commits
<llvm-commits at lists.llvm.org> writes:

> smeenai created this revision.
> Herald added a subscriber: mgorny.
>
> This adds install-*-stripped targets that strip during installation.
>
>
> https://reviews.llvm.org/D40688
>
> Files:
>   cmake/modules/AddLLD.cmake
>
>
> Index: cmake/modules/AddLLD.cmake
> ===================================================================
> --- cmake/modules/AddLLD.cmake
> +++ cmake/modules/AddLLD.cmake
> @@ -25,11 +25,9 @@
>        RUNTIME DESTINATION bin)
>  
>      if (${ARG_SHARED} AND NOT CMAKE_CONFIGURATION_TYPES)
> -      add_custom_target(install-${name}
> +      add_llvm_install_targets(install-${name}
>          DEPENDS ${name}
> -        COMMAND "${CMAKE_COMMAND}"
> -          -DCMAKE_INSTALL_COMPONENT=${name}
> -          -P "${CMAKE_BINARY_DIR}/cmake_install.cmake")
> +        COMPONENT ${name})
>      endif()
>      set_property(GLOBAL APPEND PROPERTY LLD_EXPORTS ${name})
>    endif()
> @@ -60,11 +58,9 @@
>        COMPONENT ${name})
>  
>      if(NOT CMAKE_CONFIGURATION_TYPES)
> -      add_custom_target(install-${name}
> +      add_llvm_install_targets(install-${name}
>          DEPENDS ${name}
> -        COMMAND "${CMAKE_COMMAND}"
> -        -DCMAKE_INSTALL_COMPONENT=${name}
> -        -P "${CMAKE_BINARY_DIR}/cmake_install.cmake")
> +        COMPONENT ${name})
>      endif()
>      set_property(GLOBAL APPEND PROPERTY LLD_EXPORTS ${name})
>    endif()
>
>
> Index: cmake/modules/AddLLD.cmake
> ===================================================================
> --- cmake/modules/AddLLD.cmake
> +++ cmake/modules/AddLLD.cmake
> @@ -25,11 +25,9 @@
>        RUNTIME DESTINATION bin)
>  
>      if (${ARG_SHARED} AND NOT CMAKE_CONFIGURATION_TYPES)
> -      add_custom_target(install-${name}
> +      add_llvm_install_targets(install-${name}
>          DEPENDS ${name}
> -        COMMAND "${CMAKE_COMMAND}"
> -          -DCMAKE_INSTALL_COMPONENT=${name}
> -          -P "${CMAKE_BINARY_DIR}/cmake_install.cmake")
> +        COMPONENT ${name})
>      endif()
>      set_property(GLOBAL APPEND PROPERTY LLD_EXPORTS ${name})
>    endif()
> @@ -60,11 +58,9 @@
>        COMPONENT ${name})
>  
>      if(NOT CMAKE_CONFIGURATION_TYPES)
> -      add_custom_target(install-${name}
> +      add_llvm_install_targets(install-${name}
>          DEPENDS ${name}
> -        COMMAND "${CMAKE_COMMAND}"
> -        -DCMAKE_INSTALL_COMPONENT=${name}
> -        -P "${CMAKE_BINARY_DIR}/cmake_install.cmake")
> +        COMPONENT ${name})
>      endif()
>      set_property(GLOBAL APPEND PROPERTY LLD_EXPORTS ${name})
>    endif()
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits