[PATCH] D40652: [ELF] - Produce relocation section name consistent with output section name when --emit-reloc used with linker script.
Rafael Avila de Espindola via llvm-commits
llvm-commits at lists.llvm.org
Thu Nov 30 15:02:38 PST 2017
Rui Ueyama via Phabricator <reviews at reviews.llvm.org> writes:
> ruiu added inline comments.
>
>
> ================
> Comment at: ELF/Writer.cpp:91
> +StringRef elf::getOutputSectionName(InputSectionBase *S) {
> + StringRef Name = S->Name;
> +
> ----------------
> This saves only two characters. Just use S->Name instead of Name.
I agree, but please do that as a followup as otherwise the patch is much
harder to read.
Cheers,
Rafael
More information about the llvm-commits
mailing list