[PATCH] D40632: Add flag to ArchiveWriter to test GNU64 format more efficiently

Rui Ueyama via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Nov 30 14:47:12 PST 2017


ruiu added inline comments.


================
Comment at: lib/Object/ArchiveWriter.cpp:38-39
 
+static cl::opt<int> Sym64PowerOfTwo("sym64-power-of-two", cl::Hidden,
+                                    cl::init(32));
+
----------------
I think it improves code readability a bit if you rename this Sym64Threshold or something and make it have a value of 1<<32 instead of 32.


Repository:
  rL LLVM

https://reviews.llvm.org/D40632





More information about the llvm-commits mailing list