[PATCH] D40622: XOR the frame pointer with the stack cookie when protecting the stack

[Hans Wennborg via Phabricator via llvm-commits]

hans accepted this revision.
hans added a comment.
This revision is now accepted and ready to land.

Nice. This seems like the most straight-forward solution to me.



================
Comment at: llvm/lib/CodeGen/StackProtector.cpp:390
+  // impossible to emit the check in IR, so the target *must* support stack
+  // protection in SDAG, and it's fast isel 'ret' selector must implement or
+  // fall back in the presence of stack protection.
----------------
hans wrote:
> s/it's/its/
This one still applies (for the second it's)


================
Comment at: llvm/lib/Target/X86/X86InstrCompiler.td:145
 
+// These instructions XOR the frame pointer into a GPR. They are use in some
+// stack protection schemes. These are post-RA pseudos because we only know the
----------------
s/use/used/


https://reviews.llvm.org/D40622