[PATCH] D40670: Let Alloca treated as nonnull for any alloca addr space value

Nuno Lopes via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Nov 30 14:32:12 PST 2017


nlopes requested changes to this revision.
nlopes added a comment.
This revision now requires changes to proceed.

This change is incorrect.  null can be a valid pointer in a non-0 address space, and alloca may return it.
If your target's address space guarantees that alloca doesn't return null, then we can probably make this target-dependent. But we cannot simply make it unconditional; that's not correct.


https://reviews.llvm.org/D40670





More information about the llvm-commits mailing list