Re: [PATCH] D39567: [lit] Implement non-pipelined ‘mkdir’, ‘diff’ and ‘rm’ commands internally

[Zachary Turner via llvm-commits]

Yea, if reid lgtmed it, I’m fine
On Thu, Nov 30, 2017 at 12:25 PM Ying Yi <maggieyi666 at gmail.com> wrote:

> Thanks Zachary and Reid for your comments and code review.
>
> @Zachary, would it be ok with you if I commit the patch?
>
>
>
> On Wed, Nov 29, 2017 at 9:09 PM, Reid Kleckner via Phabricator <
> reviews at reviews.llvm.org> wrote:
>
>> rnk accepted this revision.
>> rnk added a comment.
>>
>> lgtm
>>
>> I think the windows asan test cases should probably use mkdir -p instead
>> but I like the changes you made to make the internal shell commands simply
>> print to stderr and return a non-zero exit code. I think that'll be simpler
>> and more readable when writing new test cases with the internal shell. The
>> test will get a FAIL status instead of an UNRESOLVED status.
>>
>>
>> https://reviews.llvm.org/D39567
>>
>>
>>
>>
>
>
> --
> Ying Yi
> SN Systems - Sony Interactive Entertainment
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20171130/e4199780/attachment.html>