[PATCH] D40660: Enable auto-linking on Windows

Shoaib Meenai via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Nov 30 11:41:29 PST 2017


smeenai added inline comments.


================
Comment at: include/__config:1266
+#if defined(_LIBCPP_ABI_MICROSOFT)
+# if defined(_DLL) && !defined(_LIBCPP_BUILDING_LIBRARY)
+#   if defined(_LIBCPP_DEBUG)
----------------
rnk wrote:
> smeenai wrote:
> > This feels more like a Windows (or perhaps COFF) thing than a Microsoft ABI thing.
> I think if you're not using the MS ABI, you're probably using the GCC-style driver to compile and link, and that is what normally adds the C++ library to the link line.
Yeah, that's fair.


https://reviews.llvm.org/D40660





More information about the llvm-commits mailing list