[PATCH] D39508: [ubsan] lit changes for lld testing, future lto testing.

[Evgenii Stepanov via Phabricator via llvm-commits]

eugenis added inline comments.


================
Comment at: test/asan/lit.cfg:172
 # Fast unwinder doesn't work with Thumb
-if re.search('mthumb', config.target_cflags) is not None:
+if '-mthumb' in config.target_cflags is not None:
   config.available_features.add('fast-unwinder-works')
----------------
I don't think "is not None" part is necessary.


================
Comment at: test/lit.common.cfg:330
+run_wrapper = []
+target_cflags = [getattr(config, 'target_cflags', None)]
+extra_cflags = []
----------------
Ah, I did not realize that cmake passes multiple flags as a string. Then mthumb in target_cflags check would not work. 

Also, if there are no flags, this would create a 1-element [None] list, which would fail to stringify later.

Sorry for the extra work. Let's revert to target_cflags being a string.



Repository:
  rCRT Compiler Runtime

https://reviews.llvm.org/D39508