[PATCH] D40397: [FuzzMutate] Correctly handle vector types in the insertvalue operation

[Phabricator via Phabricator via llvm-commits]

This revision was automatically updated to reflect the committed changes.
Closed by commit rL319442: [FuzzMutate] Correctly handle vector types in the insertvalue operation (authored by igor.laevsky).

Changed prior to commit:
  https://reviews.llvm.org/D40397?vs=124093&id=124939#toc

Repository:
  rL LLVM

https://reviews.llvm.org/D40397

Files:
  llvm/trunk/lib/FuzzMutate/Operations.cpp
  llvm/trunk/unittests/FuzzMutate/RandomIRBuilderTest.cpp


Index: llvm/trunk/lib/FuzzMutate/Operations.cpp
===================================================================
--- llvm/trunk/lib/FuzzMutate/Operations.cpp
+++ llvm/trunk/lib/FuzzMutate/Operations.cpp
@@ -216,17 +216,19 @@
 
 static SourcePred matchScalarInAggregate() {
   auto Pred = [](ArrayRef<Value *> Cur, const Value *V) {
-    if (isa<ArrayType>(Cur[0]->getType()))
-      return V->getType() == Cur[0]->getType();
+    if (auto *ArrayT = dyn_cast<ArrayType>(Cur[0]->getType()))
+      return V->getType() == ArrayT->getElementType();
+
     auto *STy = cast<StructType>(Cur[0]->getType());
     for (int I = 0, E = STy->getNumElements(); I < E; ++I)
       if (STy->getTypeAtIndex(I) == V->getType())
         return true;
     return false;
   };
   auto Make = [](ArrayRef<Value *> Cur, ArrayRef<Type *>) {
-    if (isa<ArrayType>(Cur[0]->getType()))
-      return makeConstantsWithType(Cur[0]->getType());
+    if (auto *ArrayT = dyn_cast<ArrayType>(Cur[0]->getType()))
+      return makeConstantsWithType(ArrayT->getElementType());
+
     std::vector<Constant *> Result;
     auto *STy = cast<StructType>(Cur[0]->getType());
     for (int I = 0, E = STy->getNumElements(); I < E; ++I)
Index: llvm/trunk/unittests/FuzzMutate/RandomIRBuilderTest.cpp
===================================================================
--- llvm/trunk/unittests/FuzzMutate/RandomIRBuilderTest.cpp
+++ llvm/trunk/unittests/FuzzMutate/RandomIRBuilderTest.cpp
@@ -164,4 +164,40 @@
   }
 }
 
+TEST(RandomIRBuilderTest, InsertValueArray) {
+  // Check that we can generate insertvalue for the vector operations
+
+  LLVMContext Ctx;
+  const char *SourceCode =
+      "define void @test() {\n"
+      "  %A = alloca [8 x i32]\n"
+      "  %L = load [8 x i32], [8 x i32]* %A"
+      "  ret void\n"
+      "}";
+  auto M = parseAssembly(SourceCode, Ctx);
+
+  fuzzerop::OpDescriptor Descr = fuzzerop::insertValueDescriptor(1);
+
+  std::vector<Type *> Types =
+      {Type::getInt8Ty(Ctx), Type::getInt32Ty(Ctx), Type::getInt64Ty(Ctx)};
+  RandomIRBuilder IB(Seed, Types);
+
+  // Get first basic block of the first function
+  Function &F = *M->begin();
+  BasicBlock &BB = *F.begin();
+
+  // Pick first source
+  Instruction *Source = &*std::next(BB.begin());
+  ASSERT_TRUE(Descr.SourcePreds[0].matches({}, Source));
+
+  SmallVector<Value *, 2> Srcs(2);
+
+  // Check that we can always pick the last two operands.
+  for (int i = 0; i < 10; ++i) {
+    Srcs[0] = Source;
+    Srcs[1] = IB.findOrCreateSource(BB, {Source}, Srcs, Descr.SourcePreds[1]);
+    IB.findOrCreateSource(BB, {}, Srcs, Descr.SourcePreds[2]);
+  }
+}
+
 }


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D40397.124939.patch
Type: text/x-patch
Size: 2624 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20171130/2f5ba34c/attachment.bin>