[PATCH] D38361: [ELF] Stop setting output section size early

Peter Smith via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Nov 30 04:13:08 PST 2017


peter.smith added a comment.

My apologies for PR35478, I'll take a look this afternoon. The main intention there was to guard against 0 sized SyntheticSections as the user can't always be held responsible for them. Personally I'd be in favour of making those fields optional as I clearly didn't have enough tests to catch the problem there. I also think that our tests, for good reasons, tend to look at one feature at a time and we miss out on cases where combinations of features cause problems.


https://reviews.llvm.org/D38361





More information about the llvm-commits mailing list