[PATCH] D40632: Add flag to llvm-ar to test GNU64 format more efficently

Peter Collingbourne via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Nov 29 17:30:52 PST 2017


pcc added inline comments.


================
Comment at: tools/llvm-ar/llvm-ar.cpp:102
 
+static cl::opt<int> Sym64PowerOfTwo("sym64-power-of-two", cl::Hidden);
+
----------------
ruiu wrote:
> and change this to ForceGnu64 or something.
If this flag is only meant to be used in one test, perhaps it would be better to move it into ArchiveWriter.cpp? That way, we can avoid extending the interface to the archive writer.


Repository:
  rL LLVM

https://reviews.llvm.org/D40632





More information about the llvm-commits mailing list