[llvm] r319382 - [X86] Remove some questionable looking code that seems to be looking through a VZEXT to create a larger VSEXT.

Craig Topper via llvm-commits llvm-commits at lists.llvm.org
Wed Nov 29 15:08:25 PST 2017


Author: ctopper
Date: Wed Nov 29 15:08:25 2017
New Revision: 319382

URL: http://llvm.org/viewvc/llvm-project?rev=319382&view=rev
Log:
[X86] Remove some questionable looking code that seems to be looking through a VZEXT to create a larger VSEXT.

If the input the vzext was signed this would do the wrong thing.

Not sure how to test this.

Modified:
    llvm/trunk/lib/Target/X86/X86ISelLowering.cpp

Modified: llvm/trunk/lib/Target/X86/X86ISelLowering.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/X86/X86ISelLowering.cpp?rev=319382&r1=319381&r2=319382&view=diff
==============================================================================
--- llvm/trunk/lib/Target/X86/X86ISelLowering.cpp (original)
+++ llvm/trunk/lib/Target/X86/X86ISelLowering.cpp Wed Nov 29 15:08:25 2017
@@ -18285,7 +18285,7 @@ static SDValue LowerSIGN_EXTEND_AVX512(S
 
   if (VT.is512BitVector() && InVTElt != MVT::i1 &&
       (NumElts == 8 || NumElts == 16 || Subtarget.hasBWI())) {
-    if (In.getOpcode() == X86ISD::VSEXT || In.getOpcode() == X86ISD::VZEXT)
+    if (In.getOpcode() == X86ISD::VSEXT)
       return getExtendInVec(In.getOpcode(), dl, VT, In.getOperand(0), DAG);
     return getExtendInVec(X86ISD::VSEXT, dl, VT, In, DAG);
   }




More information about the llvm-commits mailing list