[PATCH] D40620: [llvm] Add option to strip binaries during installation

[Shoaib Meenai via Phabricator via llvm-commits]

smeenai added a comment.

In https://reviews.llvm.org/D40620#939765, @beanz wrote:

> Is there a reason to add a new option instead of just adding `-DCMAKE_INSTALL_DO_STRIP=${CMAKE_INSTALL_DO_STRIP}` to the install commands?


My reasoning for not going with that approach was that, in the usual CMake setup, `CMAKE_INSTALL_DO_STRIP` is only applicable when running installation scripts, and it doesn't have any effect at configuration time. If we're adding special behavior to LLVM's build system to make the stripping flag sticky during configuration, it seemed better to make it clear that this behavior was specific to LLVM's build system and not a general CMake thing.

I guess the `install-` targets themselves are an LLVM build system thing anyway though, so their behavior is already custom. I'm happy to change it according to your suggestion.


https://reviews.llvm.org/D40620