[PATCH] D40524: Handle the case of live 16-bit subregisters in X86FixupBWInsts

Andy Kaylor via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Nov 29 11:20:29 PST 2017


andrew.w.kaylor added inline comments.


================
Comment at: lib/Target/X86/X86FixupBWInsts.cpp:204
+                                                  /*High=*/true))) {
+      return true;
+    }
----------------
craig.topper wrote:
> Drop the curlies?
I put the curlies here (and above) because they're inside a scope that needs curlies. Someone suggested to me once that I should use or not use curlies consistently throughout a given scope, but it may be that I'm applying that too broadly. clang-format seems to be happy either way. I'm also happy either way.


https://reviews.llvm.org/D40524





More information about the llvm-commits mailing list