[PATCH] D40603: [cmake] Replace -Wall with /W4 in clang-cl options now that -Wall aliases -Weverything

[Reid Kleckner via Phabricator via llvm-commits]

rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.

lgtm

This has the side effect of enabling -Wextra for Windows self-host builds. Are we sure we want to do that?



================
Comment at: cmake/modules/HandleLLVMOptions.cmake:547
+
+  # /W4 has already been added above for clang-cl.
+  if (NOT CLANG_CL)
----------------
I'd say: Don't add -Wall for clang-cl, because it maps -Wall to -Weverything for MSVC compatibility.


https://reviews.llvm.org/D40603