[PATCH] D40606: [Support/TarWriter] - Don't allow TarWriter to add the same file more than once.
Rafael Avila de Espindola via llvm-commits
llvm-commits at lists.llvm.org
Wed Nov 29 09:12:39 PST 2017
> // Append a given file to an archive.
> -void TarWriter::append(StringRef Path, StringRef Data) {
> +bool TarWriter::append(StringRef Path, StringRef Data) {
Do you expect any caller doing anything different based on the return
value? If not I would keep it returning void.
Cheers,
Rafael
More information about the llvm-commits
mailing list