[PATCH] D40604: [GlobalISel][IRTranslator] Fix crash during translation of zero sized loads and stores

Daniel Sanders via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Nov 29 08:38:55 PST 2017


dsanders added inline comments.


================
Comment at: lib/CodeGen/GlobalISel/IRTranslator.cpp:340-341
 
+  if (DL->getTypeStoreSize(LI.getType()) == 0)
+    return true;
+
----------------
I'm not sure this is correct for the load. If the load result has a use then I'd expect -verify-machineinstrs to complain about a missing def. I think we need to emit an IMPLICIT_DEF.


Repository:
  rL LLVM

https://reviews.llvm.org/D40604





More information about the llvm-commits mailing list